fix(typing): Resolve misc type ignores in schemapi.py#3545
Merged
dangotbanned merged 6 commits intovega:mainfrom Aug 18, 2024
Merged
fix(typing): Resolve misc type ignores in schemapi.py#3545dangotbanned merged 6 commits intovega:mainfrom
schemapi.py#3545dangotbanned merged 6 commits intovega:mainfrom
Conversation
This method is far too dynamic to fix everything. Removed the need for one `mypy` specific ignore as well.
Contributor
|
Thanks! I've also noticed that validation can take up a significant amount of time in contexts where milliseconds matter such as in web applications. In an application at work, I had to disable validation of charts when it's deployed to production. Maybe there are things in Python we could improve but I think part of it is also just how the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all very low-priority, but allows using
"python.analysis.typeCheckingMode": "basic"in this module, without any warnings.Planning to investigate improving the peformance of validation, which will be much easier with a live type checker